Skip to content

doc: add documentation for starting ci job via label #35551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

doc: add documentation for starting ci job via label #35551

wants to merge 1 commit into from

Conversation

@juanarbol
Copy link
Member

Special thanks to @mmarchini, this is a really awesome feature!!

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 7, 2020
codebytere
codebytere reviewed Oct 7, 2020
View reviewed changes
gengjiawen
gengjiawen reviewed Oct 8, 2020
View reviewed changes
Trott
Trott reviewed Oct 8, 2020
View reviewed changes
Flarna
Flarna approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@Flarna Flarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add that request-ci label is removed automatically once the CI job has been started.

mhdawson
mhdawson approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanarbol juanarbol force-pushed the juanarbol/add-kickoff-ci-doc branch from 1a24062 to 5cfe307 Compare October 13, 2020 23:22
juanarbol added a commit to juanarbol/node that referenced this pull request Oct 13, 2020
@juanarbol
doc: add doc for starting ci job via label
d5e6495 
PR-URL: nodejs#35551
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@juanarbol
Copy link
Member Author

Landed in d5e6495

@juanarbol juanarbol closed this Oct 13, 2020
MylesBorins pushed a commit that referenced this pull request Oct 14, 2020
@juanarbol @MylesBorins
doc: add doc for starting ci job via label
78259b6 
PR-URL: #35551
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 14, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@juanarbol @joesepi
doc: add doc for starting ci job via label
b87c97c 
PR-URL: nodejs#35551
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@juanarbol juanarbol deleted the juanarbol/add-kickoff-ci-doc branch January 19, 2021 16:25
@Dmarch28 Dmarch28 mentioned this pull request May 10, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 10, 2022
Open
@137717unity 137717unity mentioned this pull request May 10, 2022
Open
@baby636 baby636 mentioned this pull request May 10, 2022
Open
@kissofire kissofire mentioned this pull request May 10, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request May 10, 2022
Open
@ron-a20 ron-a20 mentioned this pull request May 10, 2022
Open
@molllyn1 molllyn1 mentioned this pull request May 11, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 25, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 26, 2022
Open
@137717unity 137717unity mentioned this pull request Sep 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 29, 2022
Open
This was referenced Sep 29, 2022
Open
Open
This was referenced Oct 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 6, 2022
Open
@137717unity 137717unity mentioned this pull request Oct 7, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 7, 2022
Open
This was referenced Oct 8, 2022
Open
Open
@137717unity 137717unity mentioned this pull request Oct 9, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 9, 2022
Open
@kissofire kissofire mentioned this pull request Oct 25, 2022
Open
@molllyn1 molllyn1 mentioned this pull request Oct 26, 2022
Open
@baby636 baby636 mentioned this pull request Oct 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 26, 2022
Open
This was referenced Oct 26, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@codebytere codebytere codebytere approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@mhdawson mhdawson mhdawson approved these changes

@Flarna Flarna Flarna approved these changes

+2 more reviewers

@mmarchini mmarchini mmarchini left review comments

@antsmartian antsmartian antsmartian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@juanarbol @nodejs-github-bot @Trott @antsmartian @codebytere @gengjiawen @mmarchini @mhdawson @Flarna